Fixes in panels: correct color crop + correct rendering of graph in panels #10422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves a lot of bugs related to utf8 in panels.
Special thanks to @radare who found out many of them.
Anyway, there are a lot of them left, for example:
which I'll try to solve in a later pr
A note for @radare:
This reverts a line from one of your last prs, from:
*s = Color_RESET;
to:
*s = 0;
I think you changed it because
*s = '\0'
gave a compiler error, butColor_RESET
breaks all colors in panels. Instead*s = 0
shouldn't give any warning (but I tried only with gcc).Please tell me if you think it's wrong