New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove agft tiny graph edges on by default #10167
Conversation
Failed test:
|
c11b54d
to
fd9139d
Compare
Ok green now, it was a problem with rebasing |
libr/core/cmd_anal.c
Outdated
} | ||
free (cmd); | ||
ut64 addr = input[2] ? r_num_math (core->num, input + 2) : core->offset; | ||
r_core_cmdf (core, "ag-; .agx* %lld; agg%c;", addr, input[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use PFMT64d
libr/core/cmd_anal.c
Outdated
r_core_cmd0 (core, cmd); | ||
} | ||
ut64 addr = input[2] ? r_num_math (core->num, input + 2) : core->offset; | ||
r_core_cmdf (core, "ag-; .agc* %lld; agg%c;", addr, input[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use PFMT64d
libr/core/cmd_anal.c
Outdated
} | ||
free (cmd); | ||
ut64 addr = input[2] ? r_num_math (core->num, input + 2): core->offset; | ||
r_core_cmdf (core, "ag-; .aga* %lld; agg%c;", addr, input[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use PFMT64d
libr/core/cmd_anal.c
Outdated
@@ -5722,7 +5722,10 @@ static void cmd_agraph_print(RCore *core, const char *input) { | |||
break; | |||
case 't':// "aggt" - tiny graph | |||
core->graph->is_tiny = true; | |||
int e = r_config_get_i (core->config, "graph.edges"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add {} braces
@cyanpencil can you please address those comments and rebase? |
Refactor for cleaner command handling in cmd_anal.c Fix aggt graph edges
Substitute again %lld with %PFMT64d
fd9139d
to
171e91b
Compare
Done, also changed %lld with PFMT64d from other parts of ag* code |
This should close #9962
Now
agft
, and other commands which print tiny graphs to stdout (not interactive) won't print tiny graph edges.Also refactored some code to use
r_core_cmdf
which is a lot more cleaner than constructing strings and then passing them tor_core_cmd0