Support for every output format for callgraph (agc and agC) #10103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix whitespace inside canal.c Removed graph.format option Removed comments in canal.c
radare
reviewed
May 15, 2018
libr/include/r_core.h
Outdated
| @@ -45,6 +45,13 @@ R_LIB_VERSION_HEADER(r_core); | |||
| #define R_CORE_ANAL_KEYVALUE 16 | |||
| #define R_CORE_ANAL_JSON_FORMAT_DISASM 32 | |||
|
|
|||
| #define R_CALLGRAPH_FORMAT_NO 0 | |||
There was a problem hiding this comment.
what about R_GRAPH_FORMAT insteado? RCallGraph is not a thing
SakiiR
pushed a commit
to SakiiR/radare2
that referenced
this pull request
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for the various output formats for the agc function callgraph and the agC global callgraph.
Refactored a bit
r_core_anal_callgraph()(mostly to remove tabs in output and use more intuitive flags for the format option)Removed graph.format option, as the format can be specified directly from the command.
Note: when using the
gformat letter such as inagcg,agcalways uses "gmlfcn" format, whileagCgalways uses "gml", because I think that's what the user would do in 99.9% of the cases. However if you think that it's confusing using the same letter for both tell me and I'll change it.