Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Django Templating #230

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thebeanogamer
Copy link
Member

@thebeanogamer thebeanogamer commented Jan 30, 2022

Resolves #224

This doesn't work yet, the tag gets stripped. Pushing on request from @jchristgit
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #230 (87cd0ba) into master (35b9f20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   94.40%   94.41%           
=======================================
  Files         107      108    +1     
  Lines        4754     4760    +6     
  Branches      272      272           
=======================================
+ Hits         4488     4494    +6     
  Misses        223      223           
  Partials       43       43           
Impacted Files Coverage Δ
src/backend/settings/__init__.py 76.54% <ø> (ø)
src/admin/templatetags/template_extras.py 100.00% <100.00%> (ø)
src/admin/tests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b9f20...87cd0ba. Read the comment docs.

@jchristgit
Copy link
Collaborator

I'm currently voting that even if it's ugly, we copy over the center component for now.

@jchristgit
Copy link
Collaborator

Hi Daniel. Can I help you with this?

@jchristgit
Copy link
Collaborator

Hi Daniel. Is there a way to help you with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move our Jinja2 templates to Django
3 participants