Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Celery #207

Open
0xAda opened this issue Oct 20, 2021 · 12 comments
Open

Add Celery #207

0xAda opened this issue Oct 20, 2021 · 12 comments

Comments

@0xAda
Copy link
Contributor

0xAda commented Oct 20, 2021

We need to add celery

  • clean up preevent cache generation
  • email sending
  • various events we might want to handle on event open/end
  • discord webhooks
@thebeanogamer
Copy link
Member

We keep talking about adding Celery, and we should probably bite the bullet and do it. Being able to schedule background jobs will have other uses we should probably document here.

@0xAda 0xAda changed the title Cleanup preevent cache Add Celery Oct 20, 2021
@thebeanogamer
Copy link
Member

@jerbob I defer to you here, but presumably this means we're going to need to add another container? We need to consider how that works with self-hosted instances, perhaps a job for the RACTF public address system? Would probably involve us having to write a migration tool for Docker Compose files into ractl...

I don't really want to do the hacky solution of running this as a background process in the backend container.

@jerbob
Copy link
Member

jerbob commented Oct 20, 2021

Ye s to cobfirm we need another container

@jerbob
Copy link
Member

jerbob commented Oct 20, 2021

The same way we used to start two instances for ASGI+WSGI

@thebeanogamer
Copy link
Member

We still do

@jerbob
Copy link
Member

jerbob commented Oct 20, 2021

no no nonono wait wait wait wait wait

@0xAda
Copy link
Contributor Author

0xAda commented Oct 20, 2021

wait why are we still starting two containers?

@thebeanogamer
Copy link
Member

If we're going to change this, it should probably be its own issue

@jerbob
Copy link
Member

jerbob commented Oct 20, 2021

I think we fixed that bug in app-restructure

@0xAda
Copy link
Contributor Author

0xAda commented Oct 20, 2021

I think we fixed that bug in app-restructure

Doesn't look like it, docker-compose.yml still has sockets and web

@jerbob
Copy link
Member

jerbob commented Oct 23, 2021

I think we fixed that bug in app-restructure

Doesn't look like it, docker-compose.yml still has sockets and web

Okay, we should only need a single container to handle HTTP + websockets but I suppose that's out of scope for this ticket.

@jchristgit
Copy link
Collaborator

jchristgit commented Jul 25, 2023

I have been fortunate to have used celery as part of previous employment in the past two years, and I have come to the conclusion that we must not, under any circumstances, use celery. I can provide reasons if interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants