Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements not inserted correctly #28

Open
dcpesses opened this issue Mar 20, 2017 · 0 comments
Open

Elements not inserted correctly #28

dcpesses opened this issue Mar 20, 2017 · 0 comments

Comments

@dcpesses
Copy link

When the Element.insert method is called, the element is not actually inserted into the array. Instead, it overwrites the existing element at that index.

See https://github.com/racker/node-elementtree/blame/master/lib/elementtree.js#L101

Element.prototype.insert = function(index, element)
{
  this._children[index] = element;
};

Instead, line 103 should be changed to this._children.splice(index, 0, element);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant