Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API breakage and module version: Element.remove #24

Open
shazron opened this issue Apr 23, 2015 · 3 comments
Open

API breakage and module version: Element.remove #24

shazron opened this issue Apr 23, 2015 · 3 comments

Comments

@shazron
Copy link

shazron commented Apr 23, 2015

This commit for 0.1.6: 10b3b8c

Not sure if you care about semver, but ideally since this is an incompatible API change from 0.1.5, the major version should have been bumped (or at least doc'ed)

@Kami
Copy link
Contributor

Kami commented May 23, 2015

Agreed.

Looks like we originally missed that when releasing 0.1.6.

@Kami
Copy link
Contributor

Kami commented May 23, 2015

Sadly version 0.1.6 has already been released on npm so there is not much I can do now.

I could release a new version and call it 0.2.0 (or just switch to 2.0.0), but this still won't fix a "problem" with 0.1.6 (removing / deleting a version from 0.1.6 would just be a bad idea).

@shazron
Copy link
Author

shazron commented Sep 28, 2015

Sorry for the late reply :) My suggestion is going forward for the next release you increment the major version (like you mentioned, 2.0.0 or equivalent)

matt-oakes pushed a commit to matt-oakes/cordova-lib-watchos that referenced this issue Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants