Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Direct Reply-to in RPC Tutorials #1785

Open
NielsPilgaard opened this issue Jan 13, 2024 · 4 comments
Open

Use Direct Reply-to in RPC Tutorials #1785

NielsPilgaard opened this issue Jan 13, 2024 · 4 comments

Comments

@NielsPilgaard
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I created an RPC client based on the C# RPC tutorial, and was burned by the queue declaration approach when one of our nodes went offline.
All our services using the RPC client were still online, but they were not receiving replies to requests, which sadly made them useless.

Describe the solution you'd like

I would like the RPC tutorial(s) to utilize the Direct Reply-to feature in RMQ that solves this issue entirely.

Describe alternatives you've considered

An alternative could be to mention that using a server-named queue does not work well in the scenario that a node fails, when using a RMQ cluster.

Additional context

No response

@michaelklishin
Copy link
Member

michaelklishin commented Jan 13, 2024

There are two specific reasons why tutorial six does not use Direct Reply-to (at least not right now):

  1. We need to demonstrate the concept
  2. Support for DRt is quite different in different clients, which does not help with 1

I am not against switching but we need to have at least a draft of this new versions before we can confidently say if it'd be an actual improvement overall.

@NielsPilgaard
Copy link
Contributor Author

Support for DRt is quite different in different clients, which does not help with 1

I see, that does complicate things. I'm not familiar with any other clients than the C# one sadly, so I wouldn't be able to confidently change them.

I can make a draft for the C# version, and you can determine whether it would be worth the effort to update the other tutorials, what do you think? 😊

@michaelklishin
Copy link
Member

I'd hate to potentially waste your time asking you to contribute an example that we would't use in the end.

Let me see if we can reach consensus on this on the team, then we can put together a few examples to compare.

@NielsPilgaard
Copy link
Contributor Author

Thank you, I appreciate that 😊

Please let me know if there's anything I can do to help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants