Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Compression Codecs for sub-entry #59

Open
Gsantomaggio opened this issue Jan 21, 2022 · 6 comments
Open

Add Compression Codecs for sub-entry #59

Gsantomaggio opened this issue Jan 21, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@Gsantomaggio
Copy link
Member

By default client Support None and GZIP.
We need to provide the examples for:

Snappy = 2,
Lz4 = 3,
Zstd = 4,

as external codec to be compatible with:

@Gsantomaggio Gsantomaggio added the enhancement New feature or request label Jan 21, 2022
@Gsantomaggio
Copy link
Member Author

Lz4 Example

@0UserName
Copy link
Contributor

Hi!

I looked at an example, but there was a question. Dependencies for new codecs (wrappers over calls) should be included in the current project or go independently - a separate project including the main one or its part with interfaces? As far as I understand the rabbitmq-dotnet-client project follows the principle of the minimum number of dependencies

@Gsantomaggio
Copy link
Member Author

Dependencies for new codecs (wrappers over calls) should be included in the current project or go independently

We don't want to add external dependencies. So the idea is to write the example, then it is up to the user to decide to add the dependency.

So you write your codec then add it with:

 StreamCompressionCodecs.RegisterCodec<StreamXXXCodec>(CompressionType.XXX);

@0UserName
Copy link
Contributor

0UserName commented Feb 18, 2022

So the idea is to write the example, then it is up to the user to decide to add the dependency.

That is, no need to integrate the codec into the library, but only to prepare examples. Need something like a documentation page (section in README.md)?

@Gsantomaggio
Copy link
Member Author

the idea is not to integrate the codec into the library, but only to prepare examples?

yes, maybe create a directory examples and put the code with the documentation.

@Gsantomaggio
Copy link
Member Author

Gsantomaggio commented Jul 29, 2022

@Gsantomaggio Gsantomaggio modified the milestones: 1.0.0-rc.5, 1.0.0-rc.6 Sep 5, 2022
@lukebakken lukebakken modified the milestones: 1.0.0-rc.6, 1.0.0-rc.7 Nov 7, 2022
@lukebakken lukebakken modified the milestones: 1.0.0-rc.7, 1.0.0-rc.8 Nov 15, 2022
@Gsantomaggio Gsantomaggio removed this from the 1.0.0-rc.8 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants