Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to add opentelemetry #261

Open
Gsantomaggio opened this issue Apr 12, 2023 · 4 comments
Open

Consider to add opentelemetry #261

Gsantomaggio opened this issue Apr 12, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Gsantomaggio
Copy link
Member

Is your feature request related to a problem? Please describe.

It would be helpful to add https://opentelemetry.io/ SDK to the library.

Describe the solution you'd like

It would be helpful to add https://opentelemetry.io/ SDK to the library.

Describe alternatives you've considered

No response

Additional context

No response

@Gsantomaggio Gsantomaggio added the enhancement New feature or request label Apr 12, 2023
@jonnepmyra
Copy link
Contributor

What type of metrics will be available? From our perspective we're monitoring credits per consumer and number of active consumers (with their reference) to make sure that we always have active and alive consumers on streams.

This is done via the http API today but it's quite ineffective and would be great if it was available as metrics but that might be out of context here?

@Gsantomaggio
Copy link
Member Author

we're monitoring credits per consumer and number of active consumers (with their reference) to make sure that we always have active and alive consumers on streams.

Those are server-side metrics.

We'd like to add some client-side metrics. Not sure what.
We will define some guidelines to have the same metrics for all the clients. cc @deadtrickster

@ngbrown
Copy link
Contributor

ngbrown commented Jun 7, 2023

Specific metric solutions are an application level concern, not a library concern.

Any OpenTelemetry instrumentation for the RabbitMq.Stream.Client library would need to be in a separate NuGet package to be injected at an application level. Since the event handlers and callbacks would need to be exposed anyways for any possible metrics solution, it might be best to just document a code snippet to connect the two.

@ikavgo
Copy link

ikavgo commented Jun 7, 2023

The common practice seems to be to put opentelemetry bits into opentelementry--contrib repos. So indeed a separate package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants