Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition import: ignore virtual host default queue type when it is set to undefined #10470

Open
michaelklishin opened this issue Feb 2, 2024 · 3 comments
Assignees

Comments

@michaelklishin
Copy link
Member

To be more defensive.

See #10469 for the background.

@michaelklishin
Copy link
Member Author

The value of undefined is not only accepted, it is the default value. From rabbit_definitions:

add_vhost(VHost, ActingUser) ->
    Name             = maps:get(name, VHost, undefined),
    IsTracingEnabled = maps:get(tracing, VHost, undefined),
    Metadata         = rabbit_data_coercion:atomize_keys(maps:get(metadata, VHost, #{})),
    Description      = maps:get(description, VHost, maps:get(description, Metadata, <<"">>)),
    Tags             = maps:get(tags, VHost, maps:get(tags, Metadata, [])),
    DefaultQueueType = maps:get(default_queue_type, Metadata, undefined),

So, something else must be the culprit in #10469.

@lukebakken lukebakken reopened this Feb 6, 2024
@lukebakken
Copy link
Collaborator

The problem in #10469 stems from undefined somehow being passed to this function:

https://github.com/rabbitmq/rabbitmq-server/blob/main/deps/rabbit/src/rabbit_queue_type.erl#L241-L251

I'm trying to figure out how that happens, however 🤔

@lukebakken lukebakken self-assigned this Feb 6, 2024
@lukebakken
Copy link
Collaborator

Somewhat related issue - #10515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants