Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0: remove per-vhost connection limit for protocols other than AMQP 0-9-1 #10282

Open
michaelklishin opened this issue Jan 4, 2024 · 1 comment
Assignees
Milestone

Comments

@michaelklishin
Copy link
Member

Per virtual host connection limit inevitably requires either

  • An eventually consistent counter
  • A cluster-wide query of local counters (this is what current versions like 3.12 and 3.13 have)

We also have per-node limits which do not require any of the above and use a local counter/connection table.

For 4.0, the team has decided to drop per-vhost support for protocols other than AMQP 0-9-1 (where we see them used), namely protocols like MQTT where very large numbers of concurrent connections is much more common, and that may or may not even have the concept of a virtual host (MQTT does not).

This would allow us to extent per-node connection limits to all of those protocols without paying a hefty performance penalty for newly established connections.

This discussion was initiated by some initial QA/review feedback for #9876.

@michaelklishin michaelklishin added this to the 4.0.0 milestone Jan 4, 2024
@ikavgo ikavgo self-assigned this Jan 25, 2024
@ikavgo
Copy link
Contributor

ikavgo commented Jan 31, 2024

Removed from MQTT here #9876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants