Generative testing for parser #5

camelpunch · 2016-01-20T20:42:54Z

Use a generative testing library such as https://github.com/typelift/SwiftCheck to generate tests.

Consider:

Varying quantities of data
Combinations of types being parsed
Field table types (at time of writing we don't support all field types)

(not exhaustive) Return default values when attempting to read beyond the bounds of the NSData. In future, we should consider using subdataWithRange: et al to avoid(?) these checks, and to cover other possibilities, like length being unreadable. [#5]

Do a check on the cursor before trying to get length, because we could already be at the end. [#5]

Issue #5

Tested by including a bad size in the table, which would cause the next type identifier to be garbage. Issue #5

camelpunch added the feature label Jan 20, 2016

camelpunch added a commit that referenced this issue Mar 28, 2016

Fix memory issue in parser for long string

9d64a8e

Do a check on the cursor before trying to get length, because we could already be at the end. [#5]

camelpunch added the help wanted label Apr 18, 2016

camelpunch removed the feature label Jun 6, 2016

camelpunch added a commit that referenced this issue Jun 8, 2016

Parse numbers with more overrun safety

aa76c35

Issue #5

camelpunch added a commit that referenced this issue Jun 9, 2016

Cope with unsupported fields in parser

39a18ba

Tested by including a bad size in the table, which would cause the next type identifier to be garbage. Issue #5

dumbbell added help-wanted and removed help wanted labels Jun 10, 2016

camelpunch changed the title ~~Ensure memory access is safe when parsing~~ Generative testing for parser Jun 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generative testing for parser #5

Generative testing for parser #5

camelpunch commented Jan 20, 2016 •

edited

Generative testing for parser #5

Generative testing for parser #5

Comments

camelpunch commented Jan 20, 2016 • edited

camelpunch commented Jan 20, 2016 •

edited