Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable server hostname verification by default for TLS connections #432

Open
acogoluegnes opened this issue Dec 17, 2018 · 0 comments
Open

Enable server hostname verification by default for TLS connections #432

acogoluegnes opened this issue Dec 17, 2018 · 0 comments
Assignees
@acogoluegnes
Labels
breaking-change effort-low usability
Milestone
6.0.0

Comments

@acogoluegnes
Copy link
Contributor

This should be done as soon as the developer specifies a SSLContext or a TrustStore so with all the ConnectionFactory#useSslProtocol methods, except ConnectionFactory#useSslProtocol() and ConnectionFactory#useSslProtocol(String protocol) methods, where server checks are explicitly relaxed by using the TrustEverythingTrustManager.

Disabling server hostname verification could issue a warning, just like when using TrustEverythingTrustManager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
breaking-change effort-low usability
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@acogoluegnes