Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no RecoveryCallback counterpart for RecoveryListener #424

Open
pbillen opened this issue Nov 19, 2018 · 4 comments
Open

There is no RecoveryCallback counterpart for RecoveryListener #424

pbillen opened this issue Nov 19, 2018 · 4 comments

Comments

@pbillen
Copy link

pbillen commented Nov 19, 2018

This is based on 5.5.0.

When implementing a recovery listener, I noticed that there is no RecoveryCallback counterpart for a RecoveryListener, to support lambda style of registering a callback. For most listeners (ShutdownListener, ConfirmListener, ...) we have such counterpart.

Is this something we want to add?

I'm happy to create a PR for this.

@michaelklishin
Copy link
Member

If it's a matter of adding a "lambda-version" then I'd say please submit a PR :)

@acogoluegnes
Copy link
Contributor

Sure, why not. This is likely to be a breaking change though, so it will go in 6.x, not in 5.x.

@pbillen
Copy link
Author

pbillen commented Nov 20, 2018

OK, will do in the next days. Do you agree that the callback for denoting the start of recovery (https://github.com/rabbitmq/rabbitmq-java-client/blob/master/src/main/java/com/rabbitmq/client/RecoveryListener.java#L38) is the first argument, and the the callback for denoting the completion of recovery (https://github.com/rabbitmq/rabbitmq-java-client/blob/master/src/main/java/com/rabbitmq/client/RecoveryListener.java#L30) is the second argument of the new addRecoveryListener(cb 1, cb 2) method?

@acogoluegnes
Copy link
Contributor

This looks reasonable to me. WDYT @michaelklishin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants