Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchesStrategicMerge in kustomization.yaml has been deprecated, switch to using patches #1548

Open
fortra-cloudops-platform opened this issue Jan 30, 2024 · 2 comments
Labels
bug Something isn't working never-stale Issue or PR marked to never go stale
Milestone

Comments

@fortra-cloudops-platform

Describe the bug

Kustomize has deprecated the keyword patchesStrategicMerge used in kustomization.yaml files, this feature is now supported with the patches keyword. The switch/update should be done sooner rather than later as this could start breaking those who have updated their kustomize.

To Reproduce

Build deployment manifests using a recent version of kustomize

Expected behavior
Expected not to see this when building with kustomize:

# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Screenshots

If applicable, add screenshots to help explain your problem.

Version and environment information

  • RabbitMQ Cluster Operator: 2.7.0
  • Kubernetes: 1.28
  • Kustomize: 5.2.1
@fortra-cloudops-platform fortra-cloudops-platform added the bug Something isn't working label Jan 30, 2024
Copy link

This issue has been marked as stale due to 60 days of inactivity. Stale issues will be closed after a further 30 days of inactivity; please remove the stale label in order to prevent this occurring.

@github-actions github-actions bot added the stale Issue or PR with long period of inactivity label Mar 31, 2024
@mkuratczyk mkuratczyk added never-stale Issue or PR marked to never go stale and removed stale Issue or PR with long period of inactivity labels Apr 1, 2024
@Zerpet
Copy link
Collaborator

Zerpet commented Apr 8, 2024

Thank you for noticing this. A contribution would be most welcome.

@Zerpet Zerpet added this to the 2.8.1 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never-stale Issue or PR marked to never go stale
Projects
None yet
Development

No branches or pull requests

3 participants