Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in quotes and asides #290

Open
oandregal opened this issue Oct 26, 2017 · 4 comments
Open

Links in quotes and asides #290

oandregal opened this issue Oct 26, 2017 · 4 comments

Comments

@oandregal
Copy link

I was a bit surprised quotes and asides strip the link out of the text, modifying the post entries content. I like the fact that title isn't shown for them, and I guess that's the reason why links are stripped (so the own text acts as a link to the individual post?). In individual posts, the links are there, but the styling makes it difficult to see them if you are unaware of them (which, as a reader, you are).

Would you consider a feature request / pull request that brings back the links in asides and quotes?

@oandregal
Copy link
Author

cc @raamdev

@raamdev
Copy link
Owner

raamdev commented Nov 23, 2017

@nosolosw Yes, links are stripped from the content of quotes and asides because without a title there's no way to get to the permalink for the post.

However, I wouldn't be opposed to adding a "Permalink" link to the post meta at the bottom of the post, and then removing the code that strips links out of the content for asides/quotes so that links in the content can be used.

If you'd like to submit a pull request for that, I'll be happy to review and work on merging it. :-)

@bsima
Copy link

bsima commented Jan 11, 2018

One additional problem with making the entire post a link is this: in the RSS feed, the entire content is a link. In my RSS reader, this means the entire content is blue and underlined; the pretty typography of the theme is not retained.

I don't think you need to add a "Permalink" in the post meta because the date link is already a permalink.

@bsima
Copy link

bsima commented Jan 11, 2018

To properly fix this, we should probably add an option to turn on/off the link stripping.

As a hotfix, it looks like we can just comment out this line:

add_filter( 'the_content', 'independent_publisher_maybe_linkify_the_content', 100 );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants