Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIN] Folder Dialog - New folder is renamed with a delay. #1367

Closed
Igazii opened this issue Apr 17, 2024 · 3 comments
Closed

[WIN] Folder Dialog - New folder is renamed with a delay. #1367

Igazii opened this issue Apr 17, 2024 · 3 comments
Labels

Comments

@Igazii
Copy link

Igazii commented Apr 17, 2024

Specification

  • pywebview version: 5.0.5
  • operating system: Windows 11
  • web renderer: Edge

Description

Hello. Every time i create a folder via Folder Dialog it is renamed with a delay.
Steps to reproduce:
For example I create new folder for saving files.

  1. Click on create new folder - default name is "New folder"
  2. Rename it.
  3. For a few seconds it could stay "New folder" and causes the exception: FileNotFoundError: [WinError 3] - its because new name isn't applied and folder is still using "New folder" but after few seconds new name is being applied:
    seems like the issue with FolderBrowserDialog from win forms, because SelectedPath also includes the old name ("..../New folder") on the line 635.
    Mb you have thoughts on how to deal with it, thank you:

example

image

Practicalities

  • Yes, I am willing to work on this issue myself.
@Igazii Igazii changed the title [WIN] Folder Dialog is renamed with a delay. [WIN] Folder Dialog - New folder is renamed with a delay. Apr 17, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 18, 2024
@r0x0r
Copy link
Owner

r0x0r commented May 19, 2024

Sorry for the late response, this issue flew under my radar. I managed to reproduce it, seems like it is a known issue in Winforms. Here are some workarounds. Feel free to submit a PR.
https://stackoverflow.com/questions/6647761/problem-with-folderbrowserdialog
https://stackoverflow.com/questions/36541808/folderbrowserdialog-shows-incorrect-selectedpath-after-new-folder-is-being-creat

Copy link

The message to post on the issue when closing it. If none provided, will not comment when closing an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants