Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROJ/GDAL revdep issues #2275

Open
rsbivand opened this issue Nov 28, 2023 · 5 comments
Open

PROJ/GDAL revdep issues #2275

rsbivand opened this issue Nov 28, 2023 · 5 comments

Comments

@rsbivand
Copy link
Member

In running revdeps on 1100 packages for PROJ 9.3.1 and GDAL 3.8.1, I see two types of errors when running with sf current main. One is related to changes as discussed in alarm-redist/redist#175, r-transit/tidytransit#209, but also seen over and above redist, tidytransit in: eks, stplanr, sorvi, tectonicr, move2. The other is Error in .External.graphics(C_strWidth, as.graphicsAnnot(s), pmatch(units, : invalid graphics state or Error: key.width too small, try key.width = lcm(3.15) with varying values - these could be caused by all kinds of things. Should the first st_agr.default(x) kind be expected in 1.0-15?

Otherwise no obvious problems with PROJ 9.3.1 or GDAL 3.8.1.

@edzer
Copy link
Member

edzer commented Nov 28, 2023

Thanks! The st_agr() problem is gone; how can I reproduce the key.width too small problem?

@rsbivand
Copy link
Member Author

I saw it with: gtfstools h3jsr sfdct osmextract spqdep CSHShydRology starsExtra MapGAM nngeo transfR.

It may be related to [.sf though.

Should I fetch and merge and try the failing packages wrt. st_agr ?

@rsbivand
Copy link
Member Author

rsbivand commented Nov 28, 2023

Still failing move2:
testthat.Rout.zip
00check.log

stplanr:
testthat.Rout.zip
00check.log

tidytransit:
testthat.Rout.zip
00check.log

which seem to be Error in cls[2, ]: incorrect number of dimensions after calls to sf:::is_exotic(x), maybe from 9f0c5ce.

I haven't re-checked the key.width cases yet - now checked, no improvement, I'm afraid.

edzer added a commit that referenced this issue Nov 28, 2023
edzer added a commit that referenced this issue Nov 28, 2023
reverts #2212 because of breaking revdeps
@edzer
Copy link
Member

edzer commented Nov 28, 2023

key.width is next.

@edzer
Copy link
Member

edzer commented Nov 28, 2023

  • gtfstools
  • h3jsr
  • sfdct
  • osmextract
  • spqdep
  • CSHShydRology
  • starsExtra
  • MapGAM
  • nngeo
  • transfR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants