Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are being served via imgur which has a restrictive CORS policy #1189

Open
lloydjatkinson opened this issue Aug 22, 2022 · 4 comments
Open
Assignees
Labels

Comments

@lloydjatkinson
Copy link

lloydjatkinson commented Aug 22, 2022

Hi,

Would it be possible to switch to, for example, imgbox, as shown in the README example anyway? The reason for this is that imgur now does not allow embedding of images without an API key. imgbox does not.

I came across this with getting the mission badge for the upcoming launches endpoint, I have not yet checked every endpoint.

Thanks!

@jakewmeyer jakewmeyer self-assigned this Aug 25, 2022
@jakewmeyer jakewmeyer added the Bug label Aug 25, 2022
@jakewmeyer
Copy link
Member

Definitely! I'll throw a script together this weekend to get them all moved over 👍

@jakewmeyer
Copy link
Member

@lloydjatkinson Just switched everything over, should be good now 👍

@lloydjatkinson
Copy link
Author

That's great thank you! I can still see 4 from this API, but its better than the hundreds previous 😁

image

@jakewmeyer
Copy link
Member

Might been a few lingering cache items at that point, all imgur links appear to be gone now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants