Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide local_bindings()? #212

Open
hadley opened this issue Feb 9, 2023 · 3 comments
Open

Provide local_bindings()? #212

hadley opened this issue Feb 9, 2023 · 3 comments

Comments

@hadley
Copy link
Member

hadley commented Feb 9, 2023

No description provided.

@lionel-
Copy link
Member

lionel- commented Feb 10, 2023

We'd reexport rlang::local_bindings()? Currently withr does not depend on rlang.

To properly do and undo the bindings, we need zap support to represent missing bindings, so I think this non-trivial functionality should have only one implementation and live in rlang.

In the previous discussion in #87 we decided to keep it in rlang only.

@hadley
Copy link
Member Author

hadley commented Feb 10, 2023

It's weird that it's the only local_ function that lives in rlang, and I just hit a package (evaluate) where it'd be nice to use it (it doesn't have an rlang dep)

@lionel-
Copy link
Member

lionel- commented Feb 10, 2023

rlang has a bunch of local functions:

export(local_bindings)
export(local_error_call)
export(local_interactive)
export(local_options)
export(local_use_cli)

Wouldn't evaluate benefit from adding a dependency on rlang?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants