Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should pull() also give a deprecation warning about .data$var? #335

Open
eheinzen opened this issue Feb 16, 2023 · 0 comments
Open

Should pull() also give a deprecation warning about .data$var? #335

eheinzen opened this issue Feb 16, 2023 · 0 comments

Comments

@eheinzen
Copy link

I was surprised when upgrading to tidyselect v1.2.0 that pull() doesn't also warn about using the .data$var setup.

> data.frame(x = 1) %>% pull(.data$x)
[1] 1
> data.frame(x = 1) %>% select(.data$x)
Warning: Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"x"` instead of `.data$x`
This warning is displayed once every 8 hours.
Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated.
  x
1 1

Happy to provide sessionInfo if it's helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant