Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider directory layout #591

Closed
hadley opened this issue May 18, 2017 · 5 comments
Closed

Reconsider directory layout #591

hadley opened this issue May 18, 2017 · 5 comments
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented May 18, 2017 •
edited

(i.e. the working directory needs to be the project root)

This needs to be a long term plan, but would make testthat more consistent with other packages. Would need to start by emitting warnings so that R CMD check doesn't fail, but you're encouraged to update your tests.
@hadley hadley added the feature a feature request or enhancement label Oct 2, 2017
@hadley hadley changed the title Move towards absolute directories Reconsider directory layout and contexts Oct 10, 2017
@hadley
Copy link
Member Author

hadley commented Oct 10, 2017 •
edited

It might be possible to do this as part of a bigger behaviour switch:

  • Put tests directly in tests/
  • Eliminate use of context()
  • Don't use reporters for R CMD check
  • Eliminate bare expectations

@krlmlr
Copy link
Member

krlmlr commented Nov 10, 2017

I like the idea of putting tests under tests, but why do we need to eliminate bare expectations?

@hadley
Copy link
Member Author

hadley commented Nov 10, 2017

Just because it adds a bunch of extra code and I’d rather push people towards one consistent style. I might be wrong.

@hadley hadley changed the title Reconsider directory layout and contexts Reconsider directory layout Jul 15, 2019
@hadley
Copy link
Member Author

hadley commented Jul 15, 2019 •
edited

context() is no longer necessary as of 2.1.0

@hadley
Copy link
Member Author

hadley commented Jun 16, 2020

Superseded by #1027

@hadley hadley closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @krlmlr