Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot failures shouldn't cause max failures cancellation? #1943

Open
lionel- opened this issue Mar 12, 2024 · 1 comment
Open

Snapshot failures shouldn't cause max failures cancellation? #1943

lionel- opened this issue Mar 12, 2024 · 1 comment
Labels
feature a feature request or enhancement snapshot 📷

Comments

@lionel-
Copy link
Member

lionel- commented Mar 12, 2024

Currently, by default, if you have lots of snapshot failures you need multiple runs of test() to update them all because the test run gets cancelled after a certain number of failures.

I think it would make sense to treat snapshot failures specially so they don't contribute to the failures counter and never cause a cancellation?

@hadley hadley added feature a feature request or enhancement snapshot 📷 labels Apr 17, 2024
@hadley
Copy link
Member

hadley commented Apr 17, 2024

Yeah, I think that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement snapshot 📷
Projects
None yet
Development

No branches or pull requests

2 participants