Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store code tree structures in tests #1208

Merged
merged 1 commit into from
May 19, 2024
Merged

Don't store code tree structures in tests #1208

merged 1 commit into from
May 19, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented May 13, 2024 •
edited

Closes #1206

And also remove everything that was needed for R 3.2.

Script used to delete files:

tree_files_to_delete <-
  fs::dir_ls(
    path = ".",
    glob = "*.R|*.Rprofile|*.Rmd|*.Rmarkdown|*.Rnw|*.Qmd",
    invert = TRUE,
    type = "file",
    recurse = TRUE
  ) |>
  stringr::str_subset("_tree") |>
  purrr::map_chr(fs::path_abs)

stopifnot(all(fs::file_exists(tree_files_to_delete)))

fs::file_delete(tree_files_to_delete)

@IndrajeetPatil
Don't store code tree structures in tests
575360f 
closes #1206

And also remove everything that was needed for R 3.2.
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
IndrajeetPatil
IndrajeetPatil commented May 13, 2024
View reviewed changes
.gitignore
@@ -14,6 +14,7 @@ inst/doc
revdep/
!revdep/*.md
!revdep/problems.md
tests/testthat/*/*-in_tree
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that this is correct ignore directive.

@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4f78252 is merged into main:

  • ✔️cache_applying: 161ms -> 161ms [-2.78%, +2.16%]
  • ✔️cache_recording: 526ms -> 527ms [-0.74%, +1.24%]
  • ✔️without_cache: 987ms -> 988ms [-0.38%, +0.58%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil mentioned this pull request May 14, 2024
Merged
@IndrajeetPatil IndrajeetPatil merged commit 1088ede into main May 19, 2024
18 checks passed
@IndrajeetPatil IndrajeetPatil deleted the f1206-no-code-tree-structure branch May 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzwalthert lorenzwalthert Awaiting requested review from lorenzwalthert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconsider storing code tree structure for tests by default
2 participants
@IndrajeetPatil @lorenzwalthert