Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pillar and github actions #462

Closed
ecmerkle opened this issue Jan 26, 2022 · 8 comments
Closed

pillar and github actions #462

ecmerkle opened this issue Jan 26, 2022 · 8 comments

Comments

@ecmerkle
Copy link

Hi, there seems to be an issue with my "pkgdown" github action and the new version of pillar (1.6.5). I realize that the problem may not lie with pillar, but I'd like to check whether I am missing something obvious before I dig further.

I am getting this error:

Error: Error: .onLoad failed in loadNamespace() for 'pillar', details:
  call: register()
  error: (converted from warning) Can't find generic `scale_type` in package ggplot2 to register S3 method.

The full logs of my github actions are here: https://github.com/ecmerkle/blavaan/actions

Thanks for any ideas!

@krlmlr
Copy link
Member

krlmlr commented Jan 26, 2022

Thanks, confirmed. I'm sure we can work around, I can release an update next week.

@krlmlr krlmlr closed this as completed in 4d5f3c0 Jan 27, 2022
@krlmlr
Copy link
Member

krlmlr commented Jan 27, 2022

I tested locally. Can you please confirm if this fixes the problem in your builds?

@ecmerkle
Copy link
Author

Thanks, I set my workflows to install pillar from github, and it now works.

@pat-s
Copy link

pat-s commented Jan 29, 2022

I also saw this causing issues in GHA builds (and local R CMD Check runs) today.
One example run from mlr3filters here.

I see from the commit log that the patch from above was done shortly after pillar 1.6.5 release - are their plans for another hotfix release or does one need to workaround manually for the the next weeks? Given that I see this issue in multiple repos, an upstream patch would be appreciated.

@krlmlr
Copy link
Member

krlmlr commented Jan 29, 2022

Aiming to release 1.6.6 on February 2.

@andrewelamb
Copy link

Hi! Would this be related to the issue I'm having?

@krlmlr
Copy link
Member

krlmlr commented Feb 1, 2022

Looks like it. Releasing today or tomorrow.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants