Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'archive' status/directory seems missing #40

Open
tappek opened this issue Sep 30, 2021 · 6 comments · Fixed by #41
Open

'archive' status/directory seems missing #40

tappek opened this issue Sep 30, 2021 · 6 comments · Fixed by #41

Comments

@tappek
Copy link

tappek commented Sep 30, 2021

The directory archive is used on the CRAN incoming FTP but not described in the Dashboard for status.

Description from R Journal 01/2018 (https://journal.r-project.org/archive/2018-1/cran.pdf) is:
archive reject the package, if the package does not pass the checks cleanly and the problem
are not likely to be false positives.

@llrs
Copy link
Contributor

llrs commented Sep 30, 2021

Oh, nice finding! Didn't know that the folders were documented officially.

@maelle
Copy link
Member

maelle commented Oct 1, 2021

Cool! Can any of you do a PR?

@tappek
Copy link
Author

tappek commented Oct 2, 2021

It seems, archive is now described in the text. However, it is not in the picture (status graph) and does not evaluted in the Dashboard's column folder?

@maelle
Copy link
Member

maelle commented Oct 2, 2021

I'll reopen but have no time to investigate right now, sorry.

@maelle maelle reopened this Oct 2, 2021
@llrs
Copy link
Contributor

llrs commented Oct 6, 2021

It is just that it is filtered out on the dashboard:
https://github.com/lockedata/cransays/blob/master/vignettes/dashboard.Rmd#L38

Simply commenting it or deleting would make it appear on the dashboard

@maelle maelle closed this as completed in 7453189 Oct 7, 2021
@maelle
Copy link
Member

maelle commented Oct 7, 2021

It seems to be more complicated and I can't investigate right now.

I am actually wondering whether we should show archived package as it's not really the role of cransays (if your package fails incoming check doesn't one get an email? but maybe I'm wrong!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants