Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions on how to reconstruct a crystal from pairwise distances and unit cell parameters #199

Open
sgbaird opened this issue Jun 20, 2022 · 4 comments

Comments

@sgbaird
Copy link

sgbaird commented Jun 20, 2022

I'm doing generative modeling via xtal2png which encodes the information below (see image). I'm running into the problem where reconstructed crystals are mostly exhibiting P(1) symmetry sparks-baird/xtal2png#79, which isn't desired. While I'm working on this from the generative modeling side of things (improve representation, find better generative modeling parameters & models), I'm also wondering if there's some post-processing that might be feasible with PyXtal.

Right now, I'm ignoring cell volume, space group, and pairwise distances when doing the reconstruction. I've considered incorporating these (especially space group information sparks-baird/xtal2png#79 and pairwise distances sparks-baird/xtal2png#83) into the reconstruction process.

Note that I'm also doing surrogate DFT relaxation as a post-processing step via m3gnet.

@qzhu2017
Copy link
Owner

I am not really sure about you request. If you are truly interested in this function, we can set a video meeting to discuss it.

@sgbaird
Copy link
Author

sgbaird commented Jun 24, 2022

@qzhu2017 that would be great actually.

sterling.baird@utah.edu

@sgbaird
Copy link
Author

sgbaird commented Jun 24, 2022

@qzhu2017 thanks for meeting up to chat about this! Looking forward to doing some more brainstorming.

@sgbaird
Copy link
Author

sgbaird commented Jul 8, 2022

@qzhu2017 curious if you had any additional thoughts on this? See also the comment in sparks-baird/xtal2png#83 (comment).

Any thoughts on how space group number could be used to guide reconstruction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants