Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchable docs #711

Open
osdiab opened this issue Apr 22, 2024 · 6 comments
Open

Searchable docs #711

osdiab opened this issue Apr 22, 2024 · 6 comments

Comments

@osdiab
Copy link

osdiab commented Apr 22, 2024

Right now the docs have no site wide search, which makes it hard to find things. Would be great if this docs site supported this like other modern libraries.

@thejackshelton
Copy link
Contributor

thejackshelton commented Apr 22, 2024

Completely agree. Would you like to take a stab at it @osdiab ?

@JerryWu1234
Copy link
Contributor

let me take this pr, but Could you provide any requirement for searching library that we will be using this project?

@thejackshelton
Copy link
Contributor

thejackshelton commented May 11, 2024

let me take this pr, but Could you provide any requirement for searching library that we will be using this project?

Sure! I think in particular something similar to Kobalte here:
https://kobalte.dev/docs/core/overview/introduction

qwik-ui-search.mp4

This uses Algolia, which the Qwik docs also use if you're looking for a source of inspiration.

Ideal search functionality

  • Searchable across the docs
  • Can navigate to specific sections on a page
  • It can collect feedback / search terms from users to improve the docs experience

As for the searching component behavior, you may be able to use the Qwik UI combobox for searching. It is in a big need of a refactor, but for the time being it could work (unless there is a more seamless solution).

If you run into any trouble @JerryWu1234 happy to answer questions and chat in voice! At some point I will be refactoring the Combobox in the near future.

If we think algolia is the way to go, I'd be happy to make an account for it and get us set up, and hand it off.

@JerryWu1234
Copy link
Contributor

@thejackshelton
Do I use my algolia accounts or you offer one ?

@PatrickJS
Copy link
Contributor

@shairez can you get algolia account

@shairez
Copy link
Contributor

shairez commented May 16, 2024

Just opened an algolia account for Qwik UI 🎉

If you have experience with it please DM me on discord, it'll probably save me some of the setup time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants