Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a proper error message when dimensions are invalid #63

Open
qustavo opened this issue Oct 12, 2017 · 8 comments
Open

Display a proper error message when dimensions are invalid #63

qustavo opened this issue Oct 12, 2017 · 8 comments

Comments

@qustavo
Copy link
Owner

qustavo commented Oct 12, 2017

Currently, when resizing the terminal window where HTTPLab is running, you may get this:

2017/10/12 12:42:44 invalid dimensions

when the size of the window is too small, a better error message should be displayed.

@ghost
Copy link

ghost commented Oct 12, 2017

Can I take this?

@qustavo
Copy link
Owner Author

qustavo commented Oct 13, 2017

@lgdroid sure!, I've also been thinking that instead of closing httplab and printing a proper message, we could display the error message inside a httplab view, and redraw the other views when the term sizes are restored to something valid.
Does that make sense?

@ghost
Copy link

ghost commented Oct 14, 2017

Yes, thanks. Would it be okay to do that as 2 changes?

  1. Change the message
  2. Enhance it

My reasoning is that I'm new to GitHub and I haven't got the hang of the workflow yet. Plus I've only just started with Go :-)

@qustavo
Copy link
Owner Author

qustavo commented Oct 29, 2017

@lgdroid any progress on this?

@qustavo
Copy link
Owner Author

qustavo commented Nov 10, 2017

ping @lgdroid

@ghost
Copy link

ghost commented Nov 14, 2017

Sorry for the delay. No progress to report except that my Go book has arrived and I'll be working through it now.

@ilyakaznacheev
Copy link

Still relevant?

@qustavo
Copy link
Owner Author

qustavo commented Nov 4, 2019

@ilyakaznacheev it's not very common but the error is still not being handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants