Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebrew formula #23

Open
cemo opened this issue Mar 12, 2017 · 12 comments
Open

homebrew formula #23

cemo opened this issue Mar 12, 2017 · 12 comments

Comments

@cemo
Copy link

cemo commented Mar 12, 2017

It would be nice to be integrated into homebrew.

@qustavo
Copy link
Owner

qustavo commented Mar 13, 2017

yep, that would be great, (un)fortunately I don't have a Mac, but I'll tag this issue with help wanted.

@m1ome
Copy link
Contributor

m1ome commented Apr 12, 2017

@gchaincl i am on this one, currently creating formula.

@m1ome
Copy link
Contributor

m1ome commented Apr 12, 2017

Homebrew/homebrew-core#12351 waiting to PR to be merged.

@qustavo
Copy link
Owner

qustavo commented Apr 12, 2017

Thanks for doing this @m1ome

@gwerbin
Copy link

gwerbin commented Jul 21, 2017

It looks like the PR was rejected due to not having thorough enough post-install tests. Is there something better than httplab -version? It seems the Homebrew team is OK with that kind of test only if there isn't a more thorough alternative.

@qustavo
Copy link
Owner

qustavo commented Jul 22, 2017

@gwerbin can you give me more context? What kind of test are they expecting to have?
PS: Never used brew before

@gwerbin
Copy link

gwerbin commented Jul 24, 2017

I'm not sure what they mean. You did the right thing by asking in that thread.

@qustavo
Copy link
Owner

qustavo commented Oct 18, 2017

@m1ome any progress on this?

@gwerbin
Copy link

gwerbin commented Oct 18, 2017

They're looking for some way (other than httplab -version to test that the installation went well.

@qustavo
Copy link
Owner

qustavo commented Oct 18, 2017 via email

@gwerbin
Copy link

gwerbin commented Oct 19, 2017

Evidently not, but if you can't find a better test that can be encoded in a Ruby script then your best bet is to make a case to the maintainer (the user "ilovezfs") that it's fine as-is. If not, I have an alternative tap (https://github.com/gwerbin/homebrew-tap) for software that I personally use, so I could host it there in the interim. Mind you, I'm not much of a FOSS maintainer myself so I can't guarantee it will always be up-to-date.

@qustavo
Copy link
Owner

qustavo commented Oct 23, 2017

Thanks @gwerbin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants