-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gapless Audio #283
Comments
wa3laikum alsalam, i think someone gave us a similar solution to what you suggested, but we didn't use it because in general, the MediaPlayer objects are fairly heavy. the solution i wanted to implement is to use setNextMediaPlayer methods in MediaPlayer, which was introduced as of api level 16. so i think we should go with this approach insha'Allah since it's simpler and lighter weight. |
Thanks for quick reply. First of all, I am not familiar with setNextMediaPlayer() in API 16 but I think it needs a data source which is the file of the next ayah, which is needed to be exist at the time of calling setNextMediaPlayer(). Second, can you use setNextMediaPlayer() while the app is running at level API 8? Finally, as you said that the files are downloaded before streaming them, thus no concerns needed regarding the RAM since we deal with files only. In other words, the queue would contain instances of a wrapper class that holds information about the Ayah and the file path. You would only use one instance of MediaPlayer. Thanks. |
i don't think a lot of processing is happening - the reason for the space (i think) is due to MediaPlayer itself and how it swaps out the files (since at that point, the file is already downloaded, so in theory, it should be very quick to start playing it, especially when not on an external-sdcard). |
Possible duplicate of #231 |
Salam Alaikum, I can give the link to the app repository on GitHub if liked the result. Thanks for your efforts. |
Wa alaikum assalam @vipafattal. Sounds like an awesome upgrade. Tested with "Maher Al Muaiqly", gaps are handled more graciously. Please send PR. |
wa3laikum alsalam, |
Gald you liked it! Helpful links to Exoplayer: |
today, all except 5 qaris are gapless. likely makes more sense to gapless those qaris instead at this point and remove gapped support completely. i also have a branch that switches to exoplayer (as of the end of December 2019), though I didn’t plug any special transitioning logic for gapped audio into it. can consider pushing that as the primary player in the future in sha’ Allah. |
Salam Alaikum,
The app is just impressive, may Allah bless you. I was just wondering why don't make all "التلاوات" to be gapless? Here is one way I am thinking of you can use to implement such feature:
I am a Java developer and I can help in this part. Here is my twitter account: @EngineerFouad
Best Regards~
The text was updated successfully, but these errors were encountered: