Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should be able to select the dpi for the png of the chart download #3643

Closed
mabijkerk opened this issue Feb 25, 2021 · 5 comments
Closed
Assignees
Labels
Enhancement An improvement Pinned Will never be marked as stale or auto-closed.

Comments

@mabijkerk
Copy link
Member

As far as I can tell, the dpi for png files of charts downloaded from the model is currently automatically set at 72.
See the screenshot for a sample chart below:

Screenshot 2021-02-25 at 15 28 00

In some cases it might be preferable to have a higher dpi, mainly when physically printing charts.
For printing an effective dpi of 300 is usually preferred. Though the effective dpi on the page of course also depends on the original image size and the size on the page, a standard dpi of 72 still seems a bit low.

One solution is to increase our standard dpi, but the downside of this solution is that this means that all the downloaded charts will have larger file size. Another solution is to open add a pop-up window that allows the user to choose the dpi when "Save chart as an image is clicked". Finally, if we don't think that our user will need higher resolution downloads (for example because we think that our charts will only be used online), then we don't have to do anything.

What do you think @marliekeverweij and @redekok?

@mabijkerk mabijkerk added the Enhancement An improvement label Feb 25, 2021
@mabijkerk mabijkerk self-assigned this Feb 25, 2021
@marliekeverweij
Copy link
Contributor

I have no strong opinion on this :) I think the most frequent use case for chart downloads is for a report or PowerPoint presentation (and not printing) and I am not sure what dpi is required for that

@redekok
Copy link
Contributor

redekok commented Feb 26, 2021

I would be in favour of having the possibility to download 300 dpi charts. I agree that 72 dpi is a bit low, especially when these charts are used for high-resolution slides or reports (presented on a large screen).

@mabijkerk mabijkerk assigned antw and noracato and unassigned mabijkerk Mar 10, 2021
@antw
Copy link
Contributor

antw commented Mar 10, 2021

72 comes from the standard DPI of a monitor, and html2canvas does not support custom DPI settings. I think all we can do is set a larger scale, increasing the dimensions of the image, but not the DPI.

@github-actions
Copy link

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label May 10, 2021
@rwieruch
Copy link

https://github.com/shutterstock/changeDPI worked for me.

@ChaelKruip ChaelKruip added Pinned Will never be marked as stale or auto-closed. and removed Stale Issue had no activity for 60 days and will be, or has been, closed. labels Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An improvement Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants