Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor documentation for AIMET ONNX #2893

Open
escorciav opened this issue Apr 19, 2024 · 6 comments
Open

Poor documentation for AIMET ONNX #2893

escorciav opened this issue Apr 19, 2024 · 6 comments

Comments

@escorciav
Copy link

May I know how serious is the development of aimet_onnx?
The documentation is extremely poor wrt to PyTorch 馃槩

Can we at least get proper & complete examples that anyone can run?
Sorry in advance if it's is a page rendering error

Context
I'm considering building tooling on top of aimet_onnx. Stakeholders aren't willing to share PyTorch &/Or Tensorflow code.

@quic-mangal
Copy link
Contributor

@escorciav, sorry for this, for complete examples, you could refer to Example notebooks. In the meantime, we will work on fixing this.

@escorciav
Copy link
Author

escorciav commented Apr 22, 2024

SG, Thanks for chiming in.
Opened the issue & documenting my journey such that my future-self (or others) have pointers :)

@escorciav
Copy link
Author

escorciav commented Apr 23, 2024

@quic-mangal may I know if QAT is supported off-the-shelf with onnx?
The docs says "Link (no training)"

Again, I'm considering building tooling on top of aimet_onnx.
Stakeholders aren't willing to share PyTorch &/Or Tensorflow code for various reasons.

@quic-mangal
Copy link
Contributor

@escorciav QAT is not supported for ONNX.

@escorciav
Copy link
Author

escorciav commented Apr 24, 2024

That's a bummer for my plans 馃槶 . Anyways, thanks for letting me know 馃檶

My assistant, chaggy, is "knowledgeable" till version 1.18. Chaggy often talks bs so I don't trust him 馃挴 . But, he nailed it 馃槈

BTW, do you provide the documentation as PDF? perhaps it's relevant for RAG & leveraging LLM for document Q&A

image

@quic-mangal
Copy link
Contributor

We don't provide documentation as PDF ATM. But we will take this suggestion into account. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants