Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: several events logged before connection_started #4244

Open
marten-seemann opened this issue Jan 16, 2024 · 1 comment
Open

tracer: several events logged before connection_started #4244

marten-seemann opened this issue Jan 16, 2024 · 1 comment

Comments

@marten-seemann
Copy link
Member

For example: congestion_state_updated, key_updated, version_information

There's nothing inherently wrong with that, but it would be nicer if connection_started was the very first thing that happens on a new connection.

@marten-seemann
Copy link
Member Author

The problem here is that we only emit the connection_started once we've actually decrypted the first Initial packet. Otherwise, we might log a corrupted source connection ID (and we only find this out after applying the AEAD). This means that all the code paths that log on initialization will log before that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant