Message Serializations (2) #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That change would break the interoperability spirit. Since the body strcture\format would be bound to the implementation. In other words, you could not be able to change one transport to another and hope it still works. Honestly, I don't see a good (simple enough) solution to the problem. Feel free to move it forward though If you think that the right move. I do not want to be a blocker here. That's up to you to decide. |
Once you put it this way, I understand and agree for the most part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the original PR since it stopped being updated after reviews.
For myself, I've taken the liberty and removed
StringBodyOnlyTraitsince it's debatable whether it should be part ofqueue-interopor not. I do think it can be safely discussed in another PR if needed.Second, I've removed default value for
$bodyargument, since from my point of view it hardly makes any sense to use empty messages.Fixes #27
Supersedes #28