Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is old #2631

Closed
d-schmidt opened this issue Aug 7, 2020 · 5 comments
Closed

Documentation is old #2631

d-schmidt opened this issue Aug 7, 2020 · 5 comments

Comments

@d-schmidt
Copy link

I'm struggeling to find any current docs.

http://www.querydsl.com/ and https://twitter.com/querydsl are stuck in 2016 version 4.1.3
The wiki on Github is almost empty.
I can't even find a changelog. What happened in 4.2.2 and 4.3.1?

I want to know how to tell QueryDSL to generate JDK8 Instants and not old Timestamps from DB.

@jwgmeligmeyling
Copy link
Member

QueryDSL SQL was never updated for Java 8. In fact, project was not updated for years and only recently started to get picked up again. I am one of the active contributors now, but most of my work revolves around Querydsl JPA as frankly, I am not using any of the other modules.

QueryDSL JPA supports the Java 8 date/times just fine. Which Querydsl module are you using?

@d-schmidt
Copy link
Author

d-schmidt commented Aug 10, 2020

Yes, this particular project uses querydsl-sql.

Still, did anybody update any docs or change logs?

@jwgmeligmeyling
Copy link
Member

jwgmeligmeyling commented Aug 10, 2020

We did update the documentation, but we only recently got access to the website hosting, so we still have to reupload it.

As far as QueryDSL SQL goes, the documentation for 4.1.3 is still accurate though.

@MatthewBerk
Copy link

MatthewBerk commented Nov 1, 2020

@jwgmeligmeyling Would there be a benefit to updating QueryDSL SQL to Java 8? Or do you think focus should be on QueryDSL JPA?

@jwgmeligmeyling
Copy link
Member

jwgmeligmeyling commented Nov 1, 2020

@MatthewBerk QueryDSL 5.x will require Java 8 minimally, and also support Java 9+. This includes querydsl-sql. The benefits for querydsl-sql will be that we finally support the Java 8 date/time API, and that joda-time will be completely optional. Java 8 also allows for a couple of performance improvements and generally simpler code, also opening the doors to gradually remove Guava as a runtime dependency (which likely wont happen in 5.x yet). There are definitely benefits in Java 8 for querydsl-sql, its just that no changes turned out to be required for querydsl-jpa because the ORM vendor does the heavy lifting regarding Java 8 support.

I am pretty far with my changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants