Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] how about using docker for querydsl test environment? #2621

Closed
heesuk-ahn opened this issue Jun 26, 2020 · 5 comments
Closed

[suggestion] how about using docker for querydsl test environment? #2621

heesuk-ahn opened this issue Jun 26, 2020 · 5 comments

Comments

@heesuk-ahn
Copy link
Contributor

heesuk-ahn commented Jun 26, 2020

In the current querydsl test environment, vagrant is used.

This environment is good, but it requires a number of pre-requisites. (VirtualBox, Puppet, Vagrant..)

If we provide various databases as docker compose, wouldn't it be simpler to build a test environment?

for example,

version: '2'
services:
  mysql:
    image: mysql:5.5
    environment:
      MYSQL_USER: querydsl
      MYSQL_PASSWORD: querydsl
      MYSQL_DATABASE: querydsl
      MYSQL_ROOT_PASSWORD: querydsl
    volumes:
      - /var/lib/mysql
    ports:
      - "3306:3306"
  postgre-sql:
    image: postgres:9.1
    ports:
      - "5433:5432"
    environment:
      POSTGRES_USER: querydsl
      POSTGRES_PASSWORD: querydsl
      POSTGRES_DATABASE: querydsl
      POSTGRES_ROOT_PASSWORD: querydsl
    volumes:
      - /var/lib/postgresql/data
.
.
.
(Other necessary database environments...)
@heesuk-ahn heesuk-ahn changed the title [suggestion] how about using docker fo test environment? [suggestion] how about using docker for querydsl test environment? Jun 26, 2020
@jwgmeligmeyling
Copy link
Member

It's possible. Usually, I just test against the database of my preference (which runs in Docker) and rely on CI for all various databases that are supported.

@idosal
Copy link
Member

idosal commented Jun 26, 2020

I usually just run the docker-compose file we use in CI locally.

@jwgmeligmeyling
Copy link
Member

Ah here it is: https://github.com/querydsl/querydsl/blob/master/travis/docker-compose.yml

I guess we could mention it in the README

@heesuk-ahn
Copy link
Contributor Author

Oh, docker-compose already exists! :)

I'll change it to an issue that mentions the docker-compose environment in the Readme.

@johnktims
Copy link
Member

I’ve been meaning to update the readme and move the docker-compose.yml file to the root of the project. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants