Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crossrefs: margin everything #7455

Closed
7 tasks done
Tracked by #4944
cscheid opened this issue Nov 2, 2023 · 1 comment · Fixed by #7472
Closed
7 tasks done
Tracked by #4944

crossrefs: margin everything #7455

cscheid opened this issue Nov 2, 2023 · 1 comment · Fixed by #7472
Assignees
@cscheid
Labels
bug Something isn't working crossref
Milestone
v1.5

Comments

@cscheid
Copy link
Collaborator

cscheid commented Nov 2, 2023 •
edited

  • ensure *-cap-location = "margin" works
    • HTML
      • it all works except table margin captions are centered in the margin which is ugly
      • custom floatreftargets work
    • PDF
      • [ ] tbl- and fig- works, but custom floatreftargets do not (sidecaption doesn't like being inside a custom float environment)
  • ::: column-margin ... :::
    • HTML
    • [ ] PDF. The entire code path breaks with nested floats right now. We do slightly better wrt to warnings and lifting FloatRefTargets out of the divs, but the support is necessarily limited by what we can do with marginfigure and marginnotes interactions.
@cscheid cscheid added this to the v1.4 milestone Nov 2, 2023
@cscheid cscheid self-assigned this Nov 2, 2023
@cscheid cscheid added bug Something isn't working crossref labels Nov 2, 2023
This was referenced Nov 2, 2023
Merged
Open
@cscheid cscheid changed the title crossrefs: ensure *-cap-location = "margin" works crossrefs: margin everything Nov 3, 2023
@cscheid cscheid mentioned this issue Nov 3, 2023
Merged
1 task
@cscheid cscheid modified the milestones: v1.4, v1.5 Dec 19, 2023
@cscheid
Copy link
Collaborator Author

cscheid commented May 7, 2024

We're going to have to close this without adding PDF support for custom crossreferences, because that's not really something we can do (marginfigure does something special for Figures and Tables)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cscheid cscheid

Labels
bug Something isn't working crossref
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

Crossrefs: margins quarto-dev/quarto-cli
1 participant
@cscheid