Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search doesn't do anything on ja.quarkus.io #1104

Open
yrodiere opened this issue Jan 22, 2024 · 4 comments
Open

Search doesn't do anything on ja.quarkus.io #1104

yrodiere opened this issue Jan 22, 2024 · 4 comments

Comments

@yrodiere
Copy link
Member

yrodiere commented Jan 22, 2024

I'm not sure why, but the changes to quarkusio/quarkusio.github.io#1825 seem to have been taken into account only partially on localized websites. Search on this page doesn't do anything: https://ja.quarkus.io/guides/

I thought localized sites were using the same HTML, just with text content replaced with translations, but it would seem that assumption was wrong; some of the HTML gets overridden, too?

In particular I have this structure on Quarkus.io (and we've had that structure since early last week, so before the last sync):

image

But on ja.quarkus.io we have this:

image

See also https://github.com/quarkusio/quarkusio.github.io/blob/317cacbcd097a4f51c7ac4f895c3b9a3759f7cac/guides/index.html#L135-L153 vs.

<a id="backToTop"><i class="fas fa-chevron-up"></i></a>
<section class="full-width-version-bg flexfilterbar">

Do you have any idea what's going on, @ynojima?

@yrodiere
Copy link
Member Author

yrodiere commented Jan 22, 2024

Interestingly:

@ynojima
Copy link
Member

ynojima commented Jan 23, 2024

Thank you for pointing this out.
Addressed in #1106 for ja.quarkus.io

I thought localized sites were using the same HTML, just with text content replaced with translations, but it would seem that assumption was wrong; some of the HTML gets overridden, too?

For most parts, files are parsed and sentences are replaced automatically, but in some HTML template files, templates contain template directives and they prevent the HTML parser to process the template files.
For these template files, we prepare manually translated files(https://github.com/quarkusio/ja.quarkus.io/tree/main/l10n/override/ja_JP) and override the original files to translate them.

Some localized sites that already translated HTML templates are affected, and other localized sites that haven't translated HTML templates are not affected.

ynojima added a commit that referenced this issue Jan 23, 2024
@ynojima
Copy link
Member

ynojima commented Jan 23, 2024

Now the search starts working on ja.quarkus.io. Thank you for adding this awesome feature!

@yrodiere
Copy link
Member Author

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants