Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping event fails because not providing an installation #386

Open
gsmet opened this issue Sep 26, 2022 · 0 comments
Open

Ping event fails because not providing an installation #386

gsmet opened this issue Sep 26, 2022 · 0 comments

Comments

@gsmet
Copy link
Member

gsmet commented Sep 26, 2022

When GitHub sends the ping event, it comes (or at least can come) without an installation id:

2022-09-26 12:21:11,037 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (vert.x-eventloop-thread-1) HTTP Request to / failed, error id: ef176e9c-d003-41c5-bdb3-f5f9e87ee993-1: java.lang.IllegalStateException: Unable to extract installation id from payload
at io.quarkiverse.githubapp.runtime.Routes.extractInstallationId(Routes.java:153)
at io.quarkiverse.githubapp.runtime.Routes.handleRequest(Routes.java:103)
at io.quarkiverse.githubapp.runtime.Routes_RouteHandler_handleRequest_516ab5af9409426c5dbdf44ccd172a61ce906df9.invoke(Unknown Source)
at io.quarkus.vertx.web.runtime.RouteHandler.handle(RouteHandler.java:97)
at io.quarkus.vertx.web.runtime.RouteHandler.handle(RouteHandler.java:22)
at io.vertx.ext.web.impl.BlockingHandlerDecorator.lambda$handle$0(BlockingHandlerDecorator.java:48)
at io.vertx.core.impl.ContextBase.lambda$null$0(ContextBase.java:137)
at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:264)
at io.vertx.core.impl.ContextBase.lambda$executeBlocking$1(ContextBase.java:135)
at io.quarkus.vertx.core.runtime.VertxCoreRecorder$14.runWith(VertxCoreRecorder.java:560)
at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:29)
at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:29)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:833)
at com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine(PlatformThreads.java:705)
at com.oracle.svm.core.posix.thread.PosixPlatformThreads.pthreadStartRoutine(PosixPlatformThreads.java:202)

Payload being:

Request method: POST
Accept: */*
content-type: application/json
User-Agent: GitHub-Hookshot/3116550
X-GitHub-Delivery: 32aa9f50-3d89-11ed-9544-ad100184b97e
X-GitHub-Event: ping
X-GitHub-Hook-ID: 381399736
X-GitHub-Hook-Installation-Target-ID: 241626
X-GitHub-Hook-Installation-Target-Type: integration
X-Hub-Signature: sha1=...
X-Hub-Signature-256: sha256=...

Note that there might be other payloads not coming with an installation id so we should probably handle that somehow.

@gsmet gsmet changed the title Ping event fails miserably Ping event fails because not providing an installation Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant