DynamicGraphQLClient never gets closed

[yrodiere]

This code creates a client:

quarkus-github-app/deployment/src/main/java/io/quarkiverse/githubapp/deployment/GitHubAppProcessor.java

Lines 457 to 468 in 7faa8a1

	ResultHandle gitHubGraphQLClientRh = tryBlock.loadNull();
	if (dispatchingConfiguration.requiresGraphQLClient()) {
	gitHubGraphQLClientRh = tryBlock.invokeVirtualMethod(
	MethodDescriptor.ofMethod(GitHubService.class, "getInstallationGraphQLClient", DynamicGraphQLClient.class,
	long.class),
	tryBlock.readInstanceField(
	FieldDescriptor.of(dispatcherClassCreator.getClassName(), GITHUB_SERVICE_FIELD,
	GitHubService.class),
	tryBlock.getThis()),
	installationIdRh);
	}

By calling this:

quarkus-github-app/runtime/src/main/java/io/quarkiverse/githubapp/runtime/github/GitHubService.java

Lines 119 to 140 in 978708a

	@Override
	public DynamicGraphQLClient getInstallationGraphQLClient(long installationId) {
	try {
	return createInstallationGraphQLClient(installationId);
	} catch (IOException | ExecutionException | InterruptedException e1) {
	synchronized (this) {
	try {
	// retry in a synchronized in case the token is invalidated in another thread
	return createInstallationGraphQLClient(installationId);
	} catch (IOException | ExecutionException | InterruptedException e2) {
	try {
	// this time we invalidate the token entirely and go for a new token
	installationTokenCache.invalidate(installationId);
	return createInstallationGraphQLClient(installationId);
	} catch (IOException | ExecutionException | InterruptedException e3) {
	throw new IllegalStateException(
	"Unable to create a GitHub GraphQL client for the installation " + installationId, e3);
	}
	}
	}
	}
	}

quarkus-github-app/runtime/src/main/java/io/quarkiverse/githubapp/runtime/github/GitHubService.java

Lines 157 to 177 in 978708a

	private DynamicGraphQLClient createInstallationGraphQLClient(long installationId)
	throws IOException, ExecutionException, InterruptedException {
	CachedInstallationToken installationToken = installationTokenCache.get(installationId);
	DynamicGraphQLClient graphQLClient = DynamicGraphQLClientBuilder.newBuilder()
	.url(gitHubAppRuntimeConfig.instanceEndpoint + "/graphql")
	.header(AUTHORIZATION_HEADER, String.format(AUTHORIZATION_HEADER_BEARER, installationToken.getToken()))
	.build();
	// this call is probably - it's not documented - not counted in the rate limit
	graphQLClient.executeSync("query {\n" +
	"rateLimit {\n" +
	" limit\n" +
	" cost\n" +
	" remaining\n" +
	" resetAt\n" +
	" }\n" +
	"}");
	return graphQLClient;
	}

But as far as I can tell, there is absolutely no code to call the close() method on the created client.

Maybe we should just close it after all events have been processed? (careful though, it's reactive code so it's non-trivial to say when processing ends exactly...)

Maybe it should be cached like the non-graphQL client, and renewed every 10 minutes, and closed after 20 minutes?