Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the default HTTPConduitFactory to HttpClientHTTPConduitFactory #1091

Open
ppalaga opened this issue Nov 3, 2023 · 3 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Nov 3, 2023

We can do this in the next major or minor release, once #1090 is merged.

It would be nice to run some perf benchmarks using URLConnectionHTTPConduitFactory and HttpClientHTTPConduitFactory.

Possible topics to cover:

  • Small/large payloads
  • http vs. https
@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 4, 2023

I need to figure out whether https://issues.apache.org/jira/projects/CXF/issues/CXF-8951 has any relevance to us. Although it is about JAX-RS clients, the way how the HTTP clients are managed by the two conduit implementations might be the same for JAX-WS clients.

@famod
Copy link
Contributor

famod commented Nov 14, 2023

Just FWIW, for each QCXF update in my app I'm re-checking #971 (reply in thread) and so far nothing has changed.
That's also why we pinned URLConnectionHTTPConduitFactory via config to avoid nasty surprises on a QCXF update.
Sadly, I haven't had time to take a stab at a reproducer (with and without Quarkus in the mix).

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 14, 2023

Just FWIW, for each QCXF update in my app I'm re-checking #971 (reply in thread) and so far nothing has changed. That's also why we pinned URLConnectionHTTPConduitFactory via config to avoid nasty surprises on a QCXF update. Sadly, I haven't had time to take a stab at a reproducer (with and without Quarkus in the mix).

I think it would be worth to track this as a separate issue. At least there is a clear and easy way to reproduce. Would you mind filing a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants