Checking if a chart is closed before rendering html/json #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirik-thorp
reviewed
Apr 12, 2024
Comment on lines
+111
to
+119
| def generate_html(self, document: Optional[Document] = None) -> str: | ||
| """ | ||
| Generates the HTML necessary to display the underlying chart in a PDF document. The chart is rendered in | ||
| memory, then encoded to base64 and embedded in the HTML | ||
| """ | ||
| if self._chart.closed: | ||
| self.logger.warning('Chart generation error: The chart you are trying to generate has been already closed. ' | ||
| 'Check if you are not trying to regenerate the html for an already processed chart.') | ||
| result = "<h2 class='chart-render-failure'>Failed to render chart</h1>" |
There was a problem hiding this comment.
This function has the wrong indentation level so it's not a part of the class, and all of the code below it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.