Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _t_complexity_ overrides where build_call_graph exists. #905

Open
mpharrigan opened this issue Apr 29, 2024 · 0 comments
Open

Remove _t_complexity_ overrides where build_call_graph exists. #905

mpharrigan opened this issue Apr 29, 2024 · 0 comments
Assignees

Comments

@mpharrigan
Copy link
Collaborator

The t_complexity protocol can quickly use the call graph protocol to derive accurate t counts from subbloqs. This handles meta-bloqs like Adjoint correctly.

For bloqs where build_call_graph is implemented and correct -- the _t_complexity_ override should be removed. If "leaf values" are provided by the _t_complexity_ override, they should be moved to a unit test.

This is of extreme importance for the places where the _t_complexity_(self, adjoint: bool) method has been hacked to accept an adjoint parameter.

@dstrain115 dstrain115 self-assigned this May 20, 2024
dstrain115 added a commit to dstrain115/Qualtran that referenced this issue May 24, 2024
- Part of quantumlib#905.
- Removed _t_complexity_ calculation and moved to assert
since this has a call_graph, the T count can be inferred.
dstrain115 added a commit that referenced this issue May 28, 2024
- Part of #905.
- Removed _t_complexity_ calculation and moved to assert
since this has a call_graph, the T count can be inferred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants