Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wheel-building process reproducible #6502

Open
pavoljuhas opened this issue Mar 14, 2024 · 0 comments
Open

Make wheel-building process reproducible #6502

pavoljuhas opened this issue Mar 14, 2024 · 0 comments
Assignees
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

Problem

The version string for the pre-release cirq packages at https://pypi.org/project/cirq/#history is generated from the build execution time.
As such the version date string can differ by ~30s from the commit time, for example,
cirq-1.4.0.dev20240314200117 corresponds to the 2700f95 dated

$ TZ=UTC git show -s --pretty=%cd --date=iso-local 2700f959ead6fb7c3bdcbdd96ce936e78a34843c
2024-03-14 20:00:50 +0000

This makes it more tricky to find git commit given a pre-release version. It is also not feasible to re-generate distribution wheels for an older commit.

Solution:

Derive dev-version string from the git commit time. Support wheel building for older commits in addition to the repo HEAD.

Cirq version

1.4.0.dev at 2700f95

@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Mar 14, 2024
@pavoljuhas pavoljuhas self-assigned this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Development

No branches or pull requests

1 participant