Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.12 #6460

Closed
pavoljuhas opened this issue Feb 12, 2024 · 2 comments · Fixed by #6516
Closed

Support Python 3.12 #6460

pavoljuhas opened this issue Feb 12, 2024 · 2 comments · Fixed by #6516
Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add

Comments

@pavoljuhas
Copy link
Collaborator

pavoljuhas commented Feb 12, 2024 •
edited

Description of the issue

The current development requirements in dev_tools/requirements/dev.env.txt do not work, because pylatex~=1.3.0 does not install on Python 3.12.1. There may be possibly more incompatible packages which were enqueued for installation after pylatex.

$ pip3.12 install "pylatex~=1.3.0"
...
      AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
      [end of output]

Cirq version

1.4.0.dev at c3de706
@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Feb 12, 2024
@NoureldinYosri
Copy link
Collaborator

related to this, should we drop python3.9?

@maffoo
Copy link
Contributor

maffoo commented Feb 13, 2024

If we're following numpy's schedule, the date to drop python 3.9 support is April 5, 2024: https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule

@verult verult added the triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add label Feb 14, 2024
@NoureldinYosri NoureldinYosri mentioned this issue Feb 14, 2024
Closed
@pavoljuhas pavoljuhas mentioned this issue Mar 21, 2024
Merged
pavoljuhas added a commit that referenced this issue May 9, 2024
@pavoljuhas
Support Python 3.12 (#6516)
46eab2d 
- Fix attribute error in `engine_test.py::test_create_context`
- Adjust package presence assertion in `test_isolated_env_cloning`
- Bump up to virtualenv>=20.23, filelock~=3.1, pylatex~=1.4
- Bump up to grpcio-tools~=1.59.0 and recompile protos
- Relax qiskit-aer requirement to qiskit-aer~=0.12.0.  Allow qiskit-aer-0.12.0
  which has source archive on PyPI and can be installed for Python 3.12.
- Bump up to quimb~=1.7 which installs correctly with Python 3.12
  Remove quimb-only dependencies from our requirements, let
  quimb sort out its dependencies itself.
- CI - add pytest jobs with Python 3.12
- Skip mysteriously failing test of Contract-a-Grid-Circuit.ipynb

Fixes #6460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Python 3.12 pavoljuhas/Cirq
4 participants
@maffoo @verult @pavoljuhas @NoureldinYosri