You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These have changed a lot recently and I want to get my head clearly around these functions, and how we package them together and document them. I'm starting this issue to flag it but will continue to develop the notes here.
Functions affected:
object2id()
object2fixed()
pattern2id()
pattern2fixed()
index_types()
index() (aka locate())
The text was updated successfully, but these errors were encountered:
So what I meant in this PR is that especially for object2*() and pattern2*() functions, these are important building blocks of our functionality that could be useful by other developers (or by our future selves or other quanteda developers). These function in similar ways but it's not clear which should be used when.
NOTE: We don't necessarily need these tidied up before v3 release, since they are internal, but I think that tidying them up could help met the goal you expressed of promoting core functions for developers. For instance if we create a developer vignette and talk about some of our internal functions and structures.
I wonder why we do not consolidate them in pattern2*() since the input objects are also valid inputs listed in ?pattern.
Also the 2id functions are like an lapply(match(). The return for ?match():
match: An integer vector giving the position in table of the first match if there is a match, otherwise nomatch.
Would it make more sense to describe the function more this way? and potentially name it to reflect the similarity with match?
These have changed a lot recently and I want to get my head clearly around these functions, and how we package them together and document them. I'm starting this issue to flag it but will continue to develop the notes here.
Functions affected:
object2id()
object2fixed()
pattern2id()
pattern2fixed()
index_types()
index()
(akalocate()
)The text was updated successfully, but these errors were encountered: