Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA of 'by product' shampoo and surface cleaner plots #138

Open
kdionisio opened this issue Jun 22, 2017 · 2 comments
Open

QA of 'by product' shampoo and surface cleaner plots #138

kdionisio opened this issue Jun 22, 2017 · 2 comments

Comments

@kdionisio
Copy link
Contributor

kdionisio commented Jun 22, 2017

I don't think these are displaying correctly. The chemicals being displayed are correct, but the tails of the distributions seem to not be showing up. The curves have the correct general shape but might be shifted? Have you taken into account the people with zero dose? We may need to look at this one together for QA, comparing my plots generated in R with your plots generated through the web tool. (Note to Kathie do a QA check for deodorant, air freshener, hair color, and nail polish also)

@kdionisio kdionisio added the bug label Jun 22, 2017
@kdionisio kdionisio changed the title by product-shampoo and surface cleaner plots QA of 'by product' shampoo and surface cleaner plots Jun 22, 2017
@dmlyons2 dmlyons2 added the hard label Jun 28, 2017
@dmlyons2
Copy link
Contributor

dmlyons2 commented Jun 28, 2017

  1. Need testing
  2. Screenshots of R plots

@dmlyons2 dmlyons2 added this to the Production release 1.X milestone Jun 28, 2017
@kdionisio
Copy link
Contributor Author

kdionisio commented Jun 28, 2017

Hold on this for now...let me double check that these plots are from the same data set.

Preliminary plots to use for QA comparison of web tool plots. Below plots were generated using the same data set feeding the web tool, but generated in R. The black 'aggregate' line should match the plotted line which appears when you enter 'by chemical,', the colored lines for 'shampoo' (green) should match the plotted lines for glycerol and ethanol when you enter 'by product.' (note the former will only be true AFTER ticket #141 is complete).
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Eoraptor
Awaiting triage
Development

No branches or pull requests

2 participants