Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add License file #27

Open
jdswensen opened this issue Sep 13, 2019 · 6 comments · May be fixed by #31
Open

Add License file #27

jdswensen opened this issue Sep 13, 2019 · 6 comments · May be fixed by #31

Comments

@jdswensen
Copy link

It is my understanding that in order to follow the terms of the MIT license, a license text file that covers the entire project or notices in each file is required.

I am looking specifically at this line of text from the license:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

I believe that only including "MIT" in the Cargo.toml is not legally binding.
@camdenorrb
Copy link

Please? <3

@jdswensen jdswensen linked a pull request Apr 9, 2020 that will close this issue
Open
@jdswensen
Copy link
Author

Made a PR. All that's needed is to hit merge.

@lukevp
Copy link

lukevp commented Aug 30, 2020

@quadrupleslap any way you could approve this PR for us so the MIT license is official? You can also tag it in Github as MIT and it will show on the dashboard.

@jdswensen
Copy link
Author

Since its been about a year at this point, I sent quadrupleslap an email just in case they have github notifications turned off or filtered in their email client.

email

@apatrushev
Copy link

Since its been about a year at this point, I sent quadrupleslap an email just in case they have github notifications turned off or filtered in their email client.

email

Did you receive any answer?

@jdswensen
Copy link
Author

Nope. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add MIT license jdswensen/scrap
4 participants
@apatrushev @lukevp @jdswensen @camdenorrb